[16.0][FIX] account_invoice_report_grouped_by_picking: Method abs is called when remaining_qty is near of zero #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
approved these changes
Oct 18, 2024
carlosdauden
force-pushed
the
16.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
from
62b6990 to
5b29c2a
Compare
… when remaining_qty is near of zero Cherry-pick a38da1d
…plify and remove OrderedDict From Python 3.7 dictionaries maintain the insertion order, so OrderedDict is unnecessary and adds overhead.
carlosdauden
force-pushed
the
16.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
from
5b29c2a to
395a4c1
Compare
pedrobaeza
approved these changes
Oct 18, 2024
chienandalu
approved these changes
Oct 18, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 14944ea. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes code refactoring
FWPort #337
@Tecnativa
Ping @sergio-teruel @chienandalu